Dev - #2745
Merged
Merged
Conversation
…-onboarding AB#33927 update for seeder for onboarding match feature case
bugfix/AB#33901-SavedStates-ButtonChallenge
ABP composes pages from many independently-authored widgets and dynamically
bundles their scripts together at runtime, so widgets have no visibility into
what else will share the page. This codebase relies on nesting helper
functions inside each widget's own $(function(){...}) DOM-ready handler as an
isolation boundary against same-named helpers in other widgets. S7721
(\"Functions should be moved to the highest possible scope\") pushes those
helpers to module/global scope, which breaks that isolation and has already
caused a production cross-widget name collision.
AB#33922 exclude S7721 for JS widget scripts
AB#33922 update the S7721 exclusion for sonar scan
AB#33922 label for syntax
feature/AB#33603-FixFullName
feature/AB#33938-TinyMceTools
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.