forbid(missing_docs) and nightly compiler#52
Draft
ounsworth wants to merge 28 commits into
Draft
Conversation
…r the impl for SHA2 and SHA3.
…m the same patch stream
…sh function OIDs. Honestly, this is MUCH cleaner anyway.
ounsworth
force-pushed
the
feature/mikeo/missing_docs_and_nightly_compiler
branch
from
b29f36a to
1dc415b
Compare
ounsworth
force-pushed
the
feature/mikeo/missing_docs_and_nightly_compiler
branch
from
bacec5a to
b1e5483
Compare
ounsworth
force-pushed
the
feature/mikeo/missing_docs_and_nightly_compiler
branch
from
ca9c292 to
3356016
Compare
ounsworth
force-pushed
the
feature/mikeo/missing_docs_and_nightly_compiler
branch
from
3356016 to
4624785
Compare
…sing_docs]). Also a small refactor to remove the redundant DUMMY_SEED_512 from core-test-framework.
npajkovsky
reviewed
Jul 10, 2026
| // URLSafe, | ||
|
|
||
| #![forbid(unsafe_code)] | ||
| #![forbid(missing_docs)] |
Collaborator
There was a problem hiding this comment.
If you want to maintain your sanity at a reasonable level, try this
root/Cargo.toml
[workspace.lints]
rust.missing_docs = "warn"
and each crate will have in Cargo.toml
[lints]
workspace = true
Contributor
Author
There was a problem hiding this comment.
I'll give that a try. Thanks.
ounsworth
changed the title
Contributor
Author
|
@officialfrancismendoza I had to comment out his test at keccak.rs:545 because it's failing and I can't figure out what it's supposed to be testing, so I'll need you to debug it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stacks on top of #48
This PR is going to be a round-up of a bunch of docs changes and refactorings related to removing the nightly compiler requirement.
#As a side-effect of removing nightly / unstable, I refactored how OIDs are carried for HashMLDSA to a more general trait in core, which actually is a much better design anyway.