Allow Kangaroo doFinal after doOutput - #2409
Closed
tonywasher wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the PR, now merged with revisions. Update is on https://www.bouncycastle.org/betas - source changes should appear on github shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kangaroo doFinal call performs a check to ensure that it is not already squeezing, and throws an exception if it is already squeezing. However multiple doOutput calls followed by a doFinal is a valid sequence and is supported on all other Xof models (SHAKE/Blake3/Ascon).
The check is redundant and should be deleted.