Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Jan 25, 2025

Closes #33

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@forman forman self-assigned this Jan 25, 2025
@codecov
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (c247a7e) to head (13f7332).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   97.47%   97.52%   +0.04%     
==========================================
  Files          62       62              
  Lines        2459     2503      +44     
  Branches      346      357      +11     
==========================================
+ Hits         2397     2441      +44     
  Misses         31       31              
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman marked this pull request as ready for review January 25, 2025 15:42
@forman forman merged commit 7390352 into main Jan 25, 2025
6 checks passed
@forman forman deleted the forman-33-fix_and_enhance_time_coord_rule branch January 25, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule time-coordinate misclassifies time units as invalid

2 participants