Fix ordering of --remap-path-prefix flags.#4008
Merged
krasimirgg merged 2 commits intobazelbuild:mainfrom May 5, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
These flags are interpreted in reverse order (see rust-lang/rust#82108), and if we have a set of flags like: ``` --remap-path-prefix=/a/b/c/d=. --remap-path-prefix=/a/b=. ``` then the first flag will never apply, because the path will be first rewritten as ./c/d. In this case, output_base is the outermost directory, so we need to make sure it's remapped last.
UebelAndre
approved these changes
Apr 30, 2026
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Looks good to me! One optional nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flags are interpreted in reverse order (see
rust-lang/rust#82108), and if we have a set of flags like:
then the first flag will never apply, because the path will be first rewritten as ./c/d.
In this case, output_base is the outermost directory, so we need to make sure it's remapped last.