Add action type set diff tests, clean up#686
Closed
armandomontanez wants to merge 1 commit into
Closed
Conversation
Adds diff tests to make reviewing changes to action type set structure easier. Also reorganizes the action type sets to reduce some duplication.
armandomontanez
requested review from
c-mita,
pzembrod and
trybka
as code owners
armandomontanez
added
P3
armandomontanez
added
the
untriaged
lilygorsheneva
approved these changes
Apr 15, 2026
keith
reviewed
Apr 30, 2026
Comment on lines
+243
to
+244
| # This matches `compile_actions` with `lto_backend` omitted, because | ||
| # `lto_backend` actions do not instantiate the full set of build variables. |
Member
There was a problem hiding this comment.
comment is in the wrong place i think
keith
reviewed
Apr 30, 2026
| ) | ||
|
|
||
| cc_action_type_set( | ||
| name = "compile_actions_without_header_parsing", |
Member
There was a problem hiding this comment.
as a test case probably worth adding the use of this to this pr, which is how i found this issue:
load("//cc/toolchains:args.bzl", "cc_args")
load("//cc/toolchains:feature.bzl", "cc_feature")
cc_feature(
name = "feature",
args = [
":flags",
":header_parsing_flags",
],
overrides = "//cc/toolchains/features/legacy:compiler_input_flags",
visibility = ["//visibility:public"],
)
cc_args(
name = "flags",
actions = ["//cc/toolchains/actions:compile_actions_without_header_parsing"],
args = [
"-c",
"{source_file}",
],
format = {"source_file": "//cc/toolchains/variables:source_file"},
requires_not_none = "//cc/toolchains/variables:source_file",
)
cc_args(
name = "header_parsing_flags",
actions = ["//cc/toolchains/actions:cpp_header_parsing"],
args = ["{source_file}"],
format = {"source_file": "//cc/toolchains/variables:source_file"},
requires_not_none = "//cc/toolchains/variables:source_file",
)I think this is where exclusions would be more clear for spotting bugs
Collaborator
Author
There was a problem hiding this comment.
The request to properly split assembly and preprocess assembly actions also might benefit from exclusions.
Collaborator
Member
|
@armandomontanez might need a follow up for my comment above |
armandomontanez
commented
May 15, 2026
Collaborator
Author
armandomontanez
left a comment
armandomontanez
left a comment
There was a problem hiding this comment.
@armandomontanez might need a follow up for my comment above
Gah--I was out traveling last week and this got buried in my inbox.
| ) | ||
|
|
||
| cc_action_type_set( | ||
| name = "compile_actions_without_header_parsing", |
Collaborator
Author
There was a problem hiding this comment.
The request to properly split assembly and preprocess assembly actions also might benefit from exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds diff tests to make reviewing changes to action type set structure easier. Also reorganizes the action type sets to reduce some duplication.