Repository navigation
ci: use dict/sets for build_flags and test_flags in presubmit.yml - #4263
Merged
rickeylev merged 1 commit intoOct 14, 2026
Merged
Conversation
Using YAML lists for `build_flags` and `test_flags` prevents merging flag sets across job configurations with YAML `<<:` merge keys. Convert `build_flags` and `test_flags` entries from `-` list items to `?` mapping keys so reusable flag sets can be composed via YAML merges.
dougthor42
approved these changes
Oct 14, 2026
dougthor42
left a comment
dougthor42
left a comment
Collaborator
There was a problem hiding this comment.
/cry yaml is a terrible spec
Collaborator
Author
it makes me look upon gcl with fondness |
rickeylev
enabled auto-merge
October 14, 2026 16:32
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using YAML lists for
build_flagsandtest_flagsprevents mergingflag sets across job configurations with YAML
<<:merge keys.Convert
build_flagsandtest_flagsentries from-list items to?mapping keys so reusable flag sets can be composed via YAML merges.