Repository navigation
fix(sphinx): prefix sphinx binary paths with ./ in run script (#4201) - #4261
Merged
Merged
Conversation
…contrib#4201) When the sphinx binary target is in the root package, its short_path contains no directory separator. Executing it via `env` in the `.run` script searches `$PATH` instead of the current directory and fails with `No such file or directory`. Prefix `%SPHINX_RUNFILES_PATH%` and `%SPHINX_EXEC_PATH%` with `./` in `sphinx_run_template.sh` so `env` resolves the binary relative to the working directory. Fixes bazel-contrib#4201
aignas
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the sphinx binary target is in the root package, its short_path contains no directory separator. Executing it via
envin the.runscript searches$PATHinstead of the current directory and fails withNo such file or directory.Prefix
%SPHINX_RUNFILES_PATH%and%SPHINX_EXEC_PATH%with./insphinx_run_template.shsoenvresolves the binary relative to the working directory.Fixes #4201