Repository navigation
build(release): harden the release tools workflow - #4256
Merged
Merged
Conversation
The release tools workflow could drift from dev/platforms unnoticed, hold a runner for six hours if a build hung, and only warn when a job asked for a platform that its ref lacks. It also didn't check that the Windows files are for the right CPU, though the i686 one is cross-compiled. A test now checks that the workflow's matrix and dev/platforms name the same platforms. Jobs time out after 30 minutes; builds take a few minutes. build.sh fails with an error if dev/platforms lacks the job's platform, since that's the caller's mistake; other build failures still only warn. Jobs still skip the build for refs without dev/platforms, like older release branches. verify.sh checks that each Windows file is a PE file for the triple's CPU, reading the machine type from the PE header because `file`'s descriptions change between versions. Also explains the "musleabihf" suffix in dev/platforms, and notes in RELEASING.md that a failed "Build tools" job doesn't block a release. Work towards bazel-contrib#4216 (follow-up to bazel-contrib#4248)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release tools workflow could drift from dev/platforms unnoticed,
hold a runner for six hours if a build hung, and only warn when a job
asked for a platform that its ref lacks. It also didn't check that the
Windows files are for the right CPU, though the i686 one is
cross-compiled.
A test now checks that the workflow's matrix and dev/platforms name the
same platforms. Jobs time out after 30 minutes; builds take a few
minutes. build.sh fails with an error if dev/platforms lacks the job's
platform, since that's the caller's mistake; other build failures still
only warn. Jobs still skip the build for refs without dev/platforms,
like older release branches. verify.sh checks that each Windows file is
a PE file for the triple's CPU, reading the machine type from the PE
header because
file's descriptions change between versions.Also explains the "musleabihf" suffix in dev/platforms, and notes in
RELEASING.md that a failed "Build tools" job doesn't block a release.
Work towards #4216 (follow-up to #4248)