Skip to content

agents: clarify create-pr artifact publishing and monitor-ci pgrep #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
Oct 12, 2026
+15 −10
Merged

agents: clarify create-pr artifact publishing and monitor-ci pgrep #4247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions .agents/skills/create-pr/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ to a subagent. NEVER create or draft PRs directly in the main conversation.
rules/skills).
- **PR Body**: Explain *why* and conceptual *how*. Wrap strictly at 72
columns max. Use concise, active phrasing (Strunk & White).
- **Artifact Requirements**: Create `pr_info.md` with:
- **User-facing**: Published directly in the user interface.
- **Interactive feedback enabled**: Allows selecting lines and leaving
inline comments on the draft (`RequestFeedback: true`).
- **User decision choices**: Present choices:
- **Artifact Requirements**: Create `pr_info.md` in the subagent's own
artifact directory (do not attempt to write to the parent's artifact
directory) with:
- PR title, 72-column wrapped body, and PR number/URL (if created).
- **User decision choices**:
1. Create a regular PR
2. Create a draft PR
3. Provide feedback on the draft text
Expand All @@ -34,10 +34,13 @@ to a subagent. NEVER create or draft PRs directly in the main conversation.
`gh pr create` when explicitly requested to create the PR.
- **Targeting Upstream Repo**: When creating, target upstream using
`--repo bazel-contrib/rules_python` and `--head <fork_owner>:<branch>`.
4. **Return Status**: Direct subagent to report PR number/draft status to
caller.
5. **Link Artifact Before Asking**: Upon subagent completion, output a
clickable markdown link to `pr_info.md` before prompting for confirmation.
4. **Return Status**: Direct subagent to report the PR number/draft status and
the absolute file path to its `pr_info.md` artifact back to the caller.
5. **Publish and Link Artifact in Main Agent**: Upon subagent completion, read
the subagent's `pr_info.md` via `view_file`, publish it to the main agent's
own artifact directory via `write_to_file` (`UserFacing: true`,
`RequestFeedback: true`), and output a clickable markdown link to the main
agent's `pr_info.md` before prompting for confirmation.
6. **Interactive Actions**: When presenting choices via `ask_question`, always
include the clickable markdown link to `pr_info.md` in the `question`
prompt.
4 changes: 3 additions & 1 deletion .agents/skills/monitor-ci-results/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ or when monitoring CI after PR updates:
`pgrep -af "[m]onitor_remote_ci.py <pr_number>"`. Do NOT use a generic grep
without `<pr_number>`, as other active agent conversations may be monitoring
different PRs concurrently. If one is already running for this PR, do not
start another instance.
start another instance. Run `pgrep` as a standalone command—do NOT chain it
with `|| ... monitor_remote_ci.py <pr_number>` in a single shell invocation,
as `pgrep -af` will match the parent `bash -c` command string and exit `0`.
2. **Launch Monitoring Script**: If no monitor process is active for
`<pr_number>`, launch the script in the background:
```bash
Expand Down
Loading