Skip to content

fix(pypi): correctly override default indexes as documented in our docs - #4124

Merged
aignas merged 8 commits into
bazel-contrib:mainfrom
aignas:aignas.fix.defualt_index_url
Oct 12, 2026
Merged

aignas merged 8 commits into
bazel-contrib:mainfrom
aignas:aignas.fix.defualt_index_url

Conversation

@aignas

@aignas aignas commented Aug 29, 2026 •

Copy link
Copy Markdown
Collaborator

This fixes how defaults for pip.default(index_url) is interpreted if the
--index-url is used in a requirements.txt file arguments. From now on the
default set in pip.default takes precedence if it is set to something else
than https://pypi.org/simple.

Now behaviour is as such:

  • default - https://pypi.org/simple is used or if there is a
    requirements.txt value, it will take precedence.
  • user specifies https://pypi-internal.mirror -
    https://pypi-internal.mirror is used at all times.
  • user specifies https://pypi.org/simple - same as default

Closes #4123

@aignas aignas changed the title test(pypi): check how defaults work fix(pypi): correctly override default indexes as documented in our docs Oct 11, 2026
@aignas
aignas marked this pull request as ready for review October 11, 2026 12:26
@aignas
aignas requested a review from rickeylev as a code owner October 11, 2026 12:26
@aignas
aignas enabled auto-merge October 12, 2026 02:50
@aignas
aignas added this pull request to the merge queue Oct 12, 2026
Merged via the queue into bazel-contrib:main with commit 6563d97 Oct 12, 2026
5 checks passed
@aignas
aignas deleted the aignas.fix.defualt_index_url branch October 12, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to override https://pypi.org/simple starting in rules_python 2.0.0

2 participants