fix(pypi): harden the WORKSPACE python detection in pip_repository#3744
Open
aignas wants to merge 4 commits intobazel-contrib:mainfrom
Open
fix(pypi): harden the WORKSPACE python detection in pip_repository#3744aignas wants to merge 4 commits intobazel-contrib:mainfrom
aignas wants to merge 4 commits intobazel-contrib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Python version detection logic in pip_repository.bzl to use a Python script instead of the --version flag for more precise output. Feedback suggests further hardening the command by disabling site-packages initialization with the -S flag, improving error messages with diagnostic information, and handling potential multi-line output for better robustness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fixup to #3737