fix: replace hardcoded bm_local_path with env var#11
Merged
phernandez merged 3 commits intomainfrom Mar 15, 2026
Merged
Conversation
The justfile had a user-specific path hardcoded for bm_local_path. Now reads from BM_LOCAL_PATH env var (or .env via dotenv-load), defaulting to empty which omits --bm-local-path entirely. Also updates docs and README to use generic placeholder paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace git+https pin to @main with basic-memory>=0.20.2 from PyPI. This is the current production release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Both smoke and nightly workflows use `just` but never installed it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/Users/phernandez/...path in justfile withBM_LOCAL_PATHenv var (viaenv_var_or_default)BM_LOCAL_PATHis unset,--bm-local-pathflag is omitted entirely (CLI already defaults toNone).envsincedotenv-loadis already enabled in the justfileTest plan
uv run pytest -q— all 22 tests passjust --list— justfile parses correctlyjust --dry-run bench-run-short— no--bm-local-pathwhen unsetBM_LOCAL_PATH=/tmp/test just --dry-run bench-run-short— flag passed correctlyrg phernandez— no remaining hardcoded paths🤖 Generated with Claude Code