Repository navigation
Conversation
basert pull takes no variant, so serve <id>:<variant> pulled the default quant instead, and failed for a repo with none, such as a file-… variant taken with --pull-file. A named variant basert lists as installed is now served as --offline serves it; --pull-force still pulls.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
superfluid serve org/model:<variant>ranbasert pull org/modelbefore serving, even when that variant was installed.basert pulltakes no variant, so it fetched the default quant instead, and for a repo with no default quant it failed andserveexited:The model had been pulled with
--pull-file Qwen3.8-27B-BaseQuant-V1-Medium.base, so it was installed asfile-…-medium-<hash>. The only way to serve it again was--offline, or--pull-file, which applies to every--modeland so breaks a second one (Whisper beside it:no .base named "Qwen3.8-27B-BaseQuant-V1-Medium.base" in this repo). Local hit this as an endless restart loop.Now a variant named with the id that
basert list --jsonshows as installed is served as--offlineserves it, with no pull. A bare id still pulls (its default quant may be newer), as does a variant that isn't installed, and--pull-forcealways pulls.Testing
cargo test -p superfluid-adapter-basert: 22 pass, including the newan_installed_named_variant_is_not_pulled_againcargo clippy -p superfluid-adapter-basert --all-targets -- -D warningsis cleanSUPERFLUID_WORKER_BASERTset to this branch's worker servedbasecompute/Qwen3.8-27B-BaseQuant-V1:file-qwen3.8-27b-basequant-v1-medium-6583221f --model basecompute/whisper-tinyonline. It listed both models and answered a chat completion; the shipped worker fails on the same command as above.cargo test, and Linux/CUDA.