Repository navigation
ci: nightly prs open as a github app, against the newest rc branch - #34
Merged
Merged
Conversation
The repository does not let Actions open pull requests, so every record job since 10-22 failed at `gh pr create` after pushing its branch. A PR or push made with GITHUB_TOKEN would also start no workflow, leaving the checks main requires unrun. The record jobs now push, open PRs and write issues with a token of the nightly's GitHub App (vars.NIGHTLY_APP_ID, secrets.NIGHTLY_APP_PRIVATE_KEY); their own token drops to contents: read.
`pick` finds the newest rc-X.Y.Z branch by version, or main when no release is being cut. Every job checks it out, so the adapter is tested and the recipe read and changed as that branch has them. Against main the PRs open as drafts. An open PR whose branch changed is rebuilt on the new one, retargeted, and moved into or out of draft to match.
IsuraManchanayake
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every nightly since 10-22 has passed its tests and then failed in the record jobs:
gh pr createreturnsGitHub Actions is not permitted to create or approve pull requests, because this repository has that setting off. Turning it on would not be enough. A PR or push made withGITHUB_TOKENstarts no workflow, so the four checksmainrequires would never run on the nightly's PRs.A GitHub App writes the records.
record-llamacppandrecord-mlxnow:vars.NIGHTLY_APP_ID,secrets.NIGHTLY_APP_PRIVATE_KEY, both set) withactions/create-github-app-token@v2nightly/<runtime>is the App's and CI runs on the PRghfor the PR and issue stepscontents: read, whichnightly_runtimes.py llamacpp appendstill uses to read the build's digestsThe PRs go to the release being cut.
pickfinds the newestrc-X.Y.Zbranch by version (rc-0.1.10afterrc-0.1.9), elsemain, and outputs it asbase. Every job checksbaseout:pickandappendread and change that branch's recipeSo the claim "tested with X" holds for the branch it lands on. Against
mainthe PRs open as drafts. When an open PR's branch changes, the record job rebuildsnightly/<runtime>on the new one, retargets the PR, and moves it into or out of draft to match:mainis open: the PR moves to the rc, ready for reviewmainas a draftA
workflow_dispatchfrom another branch now only changes which workflow file runs. The code it tests is stillbase's.To check once merged, run
gh workflow run nightly-runtimes.yml --ref main. Withrc-0.1.5open, the PRs fromnightly/llamacppandnightly/mlxshould target it, be opened by the App's bot, and get CI on their own.