Drop gemspec attributes removed in RubyGems 4 - #1
Merged
Conversation
`Gem::Specification#has_rdoc=` no longer exists, so loading this gemspec
raises on Ruby 4 and every Bundler resolution that touches this gem
fails:
Bundler::GemspecError: There was an error while loading
`resque-pause.gemspec`: undefined method 'has_rdoc=' for an
instance of Gem::Specification
That has been breaking Launchpad's Dependabot runs since June — no gem
updates at all, security ones included.
`rubyforge_project` is still tolerated by RubyGems 4, but RubyForge shut
down in 2014. Removed alongside as cleanup.
Verified under ruby 4.0.6: `Gem::Specification.load` returns the spec
and `gem build` succeeds.
There was a problem hiding this comment.
Pull request overview
Removes obsolete RubyGems metadata so the gemspec loads under RubyGems 4 without changing runtime behavior or dependencies.
Changes:
- Removed unsupported
has_rdoc. - Removed defunct RubyForge metadata.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading this gemspec raises on Ruby 4, so every Bundler resolution that touches the gem fails:
Gem::Specification#has_rdoc=no longer exists. Dependabot's updater now runs Ruby 4, so this has been silently killing Launchpad's bundler runs since June — 68 dependencies checked, nothing resolvable, no gem PRs at all including security ones.rubyforge_projectis a separate matter: RubyGems 4 still tolerates it (it executes fine on the line abovehas_rdoc=), so removing it is cleanup, not the fix. RubyForge shut down in 2014.Verified under ruby 4.0.6:
No runtime code changes — version stays 0.3.0, dependencies unchanged.