This repository was archived by the owner on May 15, 2020. It is now read-only.
Add a tiny bit of extra protection for users when uninstalling.#511
Open
statwonk wants to merge 1 commit intobasecamp:masterfrom
Open
Add a tiny bit of extra protection for users when uninstalling.#511statwonk wants to merge 1 commit intobasecamp:masterfrom
statwonk wants to merge 1 commit intobasecamp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I appreciate the "review this script" call out in the uninstall procedures. I feel in general that it's bad to be habituating users to
curl/wget|shstyle installation procedures, but I'm not aware of a better solution either. In lieu of a better solution, this is my own tiny contribution to script safety for this specific script.