[robzolkos]

PR 1 of a stack of 8 that tests basecamp connect end to end. It is stacked on #822 (the fake Basecamp) and changes no behaviour of the CLI.

Why

The connect setup tests ran against connectSetupServer, a mock that answered most reads to any bearer and modeled each scenario as a field (refuseAgentReads, agentAsUser, boss, agentProjects, refuseSecret, rateLimitMints, ...). It drifted from Basecamp in small ways: project reads ignored membership, the project list was a separate field from what the agent could read, and the client secret never rotated. One fake for every connect test means a scenario is set up the way Basecamp would be, and the later e2e PRs run against the same one.

What

connect_setup_test.go, connect_setup_guided_test.go, connect_operator_test.go, connect_start_wait_test.go and profile_layers_test.go now run against internal/connector/fakebasecamp. connectSetupServer is deleted.

Each old knob is now a fact of the world or a fault:

• agentProjects -> the agent's project membership (agentOnProjects). The list and the reads agree now.
• boss -> BossID on the agent (ownedByTheOperator).
• refusePeople and the "Colleague" -> ReadableBy on the person (readableOnlyBy).
• agentAsUser -> Agent: false; grantScope -> Connection.Scope.
• agentID = 777 and agentID++ -> the client and its tokens repointed at another Agent (repointAgent).
• refuseSecret -> the secret rotated by a connection on another computer (connectedElsewhere). The fake then refuses it with invalid_client, and the reconnect rotates in a secret it accepts. No fault and no toggle are needed.
• refuseAgentReads -> 403 on project and project people reads, for Agents only.
• mintFailure -> a 422 fault on the stream ticket; agentID = 0 -> a 200 fault with a profile that has no id.
• duringMint -> Before(RouteStreamTicket, ...); rateLimitMints -> TokenRateLimited(3600); mints and intakeCount -> Count(...).

One addition to the fake: Server.Tickets() returns every stream ticket it issued. The tests check that a command never prints a ticket, so they need the real ticket values, and tickets are not part of the World. It has its own test in fakebasecamp.

Assertions. Every assertion is kept. Some are stronger now:

• The secret checks use the secret the ceremony rotated in, read from the world, not a constant.
• The ticket checks cover every ticket issued, and the first test asserts that a ticket was minted.
• TestGuidedConnectSetupLeavesARefusedCredentialThePersonKeeps now also checks that the refusal was explained and that the reconnect question was asked. Before, it passed even with a credential that was not refused.
• Hooks that run on the fake's goroutine use assert, not require.

Tests

• bin/ci green.
• The affected tests pass with go test -race -count=10 (1100 runs, no failures, no races).
• Mutation check: when the secret rotation or ReadableBy has no effect, the tests that depend on them fail.
• Timings are the same as before. The ceremony's 1s poll interval was already the main cost.

---

Summary by cubic

Migrates the connect setup tests from the custom connectSetupServer mock to the shared fake Basecamp, with no CLI behavior changes.

Refactor

• Each old mock knob is now a world fact or an injected fault, including project membership, a profile boss, people readable only by some, a rotated client secret, and a token repointed at another agent.
• The fake Basecamp gains Tickets(), listing every stream ticket it issued, so no-echo assertions compare against real tickets.
• Assertions are stronger: secret checks read the rotated secret from the world, and the refused-credential test now verifies the refusal explanation and reconnect prompt.

^{Written for commit 01f042c. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 7 files

_{Re-trigger cubic}

[Copilot]

Copilot review overview

🟢 Approved

The migration preserves the tested scenarios while improving realism, consistency, and credential-leak coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Migrates connect setup tests to the shared fake Basecamp without changing CLI behavior.

Changes:

• Replaces the bespoke setup server with realistic world state and faults.
• Adds thread-safe tracking of issued stream tickets.
• Strengthens credential and ticket leak assertions.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File	Description
internal/​connector/​fakebasecamp/​tickets_test.go	Tests issued-ticket tracking.
internal/​connector/​fakebasecamp/​cable.go	Exposes sorted ticket snapshots.
internal/​commands/​profile_layers_test.go	Uses the shared fake server.
internal/​commands/​connect_start_wait_test.go	Models token rate limits through fake faults.
internal/​commands/​connect_setup_test.go	Replaces the legacy setup mock and strengthens assertions.
internal/​commands/​connect_setup_guided_test.go	Models guided scenarios using fake world state.
internal/​commands/​connect_operator_test.go	Updates the operator fixture to use the fake server.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[jeremy]

🤖 Two things before this can land:

1. Lint is red only because of the G120 finding in Add a fake Basecamp for testing basecamp connect end to end #822. Rebasing onto Add a fake Basecamp for testing basecamp connect end to end #822 once that's fixed clears it.
2. internal/commands/connect_setup_test.go now conflicts with main. Let named operators assign the agent work, when the operator opts them in #847, Let allowed agents wake the connector by mention, with loop caps #860 and connect: the operator's boost on a declared ask is the go #879 added four setup and feed tests that use the old mock server's bodies map and setupPeerAgent, and connect_operator_test.go stops compiling on f.s.mu/f.s.bodies once the mock is gone. Those tests need porting to the fake, or the fake needs a canned-body hook.

Copilot's approval is on 4619ba70, from before the 18:23 force-push, so it will need a fresh review.

[robzolkos]

Closing: we are retaining the existing setup tests rather than rewriting them around the fake Basecamp from the retired testing stack.