Skip to content

feat(vibenet): make Base Runner share the only game-over action - #227

Merged
soheimam merged 1 commit into
mainfrom
toshi/base-runner-share-button-bds
Nov 9, 2026
Merged

soheimam merged 1 commit into
mainfrom
toshi/base-runner-share-button-bds

Conversation

@soheimam

@soheimam soheimam commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Makes Share on X the only action on the Base Runner (/vibenet/demos/200) game-over screen, and removes the onchain leaderboard.

Share button (following BDS, base/bds)

  • Uses the primary variant (Base Blue fill, same as BDS tone="brand") with the BDS x-twitter icon. The icon is copied into app/components/ui/icons.tsx (this repo hand-writes its icons).
  • No surrounding panel; it sits directly on the game's road strip, centred under the game-over card.
  • Sized and placed in game space: a ResizeObserver measures where the canvas draws (it letterboxes with object-contain), so the button keeps the same proportion to the card at any screen size. It is 36 px tall with a 13 px label on phones and in the 800 px inline layout, and up to 64 px with a 22 px label on large screens.

Onchain leaderboard removed

  • Removes the "New onchain best! / Post N onchain" prompt, a duplicate Post button (with a stray copy of the score bar) in the high-scores header, the "Onchain high scores" section, the 12 s board polling and the throwaway score wallet.
  • Deletes lib/leaderboard.ts (+ test) and contract/ (BlockRunnerScores source, ABI, deploy script); nothing else imported them.
  • Reason: the scores contract at 0x2441…e07d no longer exists on vibenet (eth_getCode returns 0x, likely a devnet regenesis), so every board read failed, every run showed the Post prompt, and every post would have failed.

The local "Best" score (stored in the browser) is unchanged.

Screenshots

Game over at 1920×1000 (immersive): the button scales with the game.

Desktop game over

Inline layout at 1280 px, with the high-scores section gone below the game:

Page without leaderboard

Phone, 390×844:

Phone game over

Test plan

  • npx vitest run app/vibenet/demos: 227/227 pass.
  • npx eslint app/vibenet/demos/200 app/components/ui/icons.tsx: clean. tsc --noEmit: no new errors (only the existing missing next-env.d.ts PNG-type error in this checkout).
  • Playwright against next dev: forced a game over at 1920×1000, 390×844 and the inline 1280 layout; checked the button size and position, that Share on X is the only game-over button, that the high-scores section is gone, and no page errors.

Share on X is now the primary game-over action, with the BDS x-twitter icon, sized and placed in game space so it stays in proportion to the game-over card. Removes the onchain leaderboard (posting, board, scores contract and deploy script): the contract no longer exists on vibenet, so every read failed and every post would have failed.
@cb-heimdall

cb-heimdall commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
1 if authored by an app that is not allowlisted and lacks verified human attribution 0
Sum 1

@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
omni-ui Ready Ready Preview Nov 9, 2026 5:50pm UTC

Request Review

@soheimam
soheimam added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit e2c5216 Nov 9, 2026
13 checks passed
@soheimam
soheimam deleted the toshi/base-runner-share-button-bds branch November 9, 2026 18:09

This branch was successfully deployed

1 active deployment
Preview — 40ca6188 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants