Repository navigation
refactor(scaling): simplify subsystem matching and drop unread limit fields - #226
Merged
Merged
Conversation
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
✅ Heimdall Review Status
|
mw2000
approved these changes
Nov 11, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the
/scalingcomponents changed in the last 7 days, with no change to rendered output:MATCHESmap inWorkloadSubsystems.tsxwith one predicate; six of its seven entries compared the id to the key.runwayYearsandworkloadfromLimitinBottlenecks.tsx; both were set, never read.YEAR_SECONDSfromBottlenecks.tsxinstead of redefining it inWorkloadSubsystems.tsx.atLeasthelper inrankLimits.Net −14 lines across two files.
Screenshots
N/A (no visual changes; same strings and ordering, covered by
scorecard.test.tsx)Test plan
Review: ready | high, 92% | standard: claude-opus-5-5 + gpt-6.1-sol
Not verified beyond CI.