fix: correct branch in thirdweb template links (main -> master)#1698
Open
haileymarshall wants to merge 1 commit into
Open
fix: correct branch in thirdweb template links (main -> master)#1698haileymarshall wants to merge 1 commit into
haileymarshall wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
The Thirdweb integration guide links to the
base-account-thirdweb-templatein thebase/demosrepo using a/tree/main/URL, but that repo's default branch ismaster, so both links 404:https://github.com/base/demos/tree/main/base-account/base-account-thirdweb-template→ 404https://github.com/base/demos/tree/master/base-account/base-account-thirdweb-template→ 200This updates both occurrences in
docs/base-account/framework-integrations/thirdweb.mdx(the inline link and theGithubRepoCard) frommaintomaster.Notes to reviewers
base/demos/tree/...links across the docs already correctly usemaster; these two were the only ones onmain.base/demosdefault branch ismasterand the template directory exists at that path.How has it been tested?
/tree/main/URL returns 404 and the/tree/master/URL returns 200.base/demos/(blob|tree|raw)/main; these two links were the only matches.