Skip to content

perf: optimize loop increment gas cost in GasPriceOracle - #427

Open
forumevi wants to merge 1 commit into
base:mainfrom
forumevi:perf/gas-optimize-calldata-gas-loop
Open

perf: optimize loop increment gas cost in GasPriceOracle#427
forumevi wants to merge 1 commit into
base:mainfrom
forumevi:perf/gas-optimize-calldata-gas-loop

Conversation

@forumevi

Copy link
Copy Markdown

Summary

Optimizes gas consumption in GasPriceOracle._getCalldataGas by wrapping the loop counter increment in an unchecked block.

Since i < length is enforced by the loop condition, i++ cannot overflow uint256. Bypassing default overflow checks saves gas per byte iteration.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants