Skip to content

Configure flashblocks leeway time#198

Merged
niran merged 1 commit into
mainfrom
configurable-flashblocks-leeway
Jun 10, 2026
Merged

Configure flashblocks leeway time#198
niran merged 1 commit into
mainfrom
configurable-flashblocks-leeway

Conversation

@niran

@niran niran commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add flashblocks.leeway_time benchmark config support
  • pass configured leeway through runtime setup to base-builder as --flashblocks.leeway-time
  • cover the new config accessor with a unit test

Tests

  • go test ./runner/...

type=routine
risk=low
impact=sev5

@cb-heimdall

cb-heimdall commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@niran niran requested review from meyer9 and wlawt June 9, 2026 20:35
wlawt
wlawt previously approved these changes Jun 10, 2026
@niran niran enabled auto-merge (squash) June 10, 2026 19:33
@niran niran force-pushed the configurable-flashblocks-leeway branch from 8f26a51 to 20f095a Compare June 10, 2026 19:45
@cb-heimdall cb-heimdall dismissed wlawt’s stale review June 10, 2026 19:45

Approved review 4470990168 from wlawt is now dismissed due to new commit. Re-request for approval.

@niran niran requested a review from wlawt June 10, 2026 19:45
@niran niran merged commit cbe8eac into main Jun 10, 2026
20 checks passed
@niran niran deleted the configurable-flashblocks-leeway branch June 10, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants