fix(smoke): align journeys with strict Rust ABI decode failures#161
Merged
Conversation
Smoke tests expected typed InvalidVariant and dirty-bit masking, but Rust precompiles reject non-canonical calldata with AbiDecodeFailed before dispatch. Add decode-failure helpers on Chain and update factory/invariant journeys. Co-authored-by: Cursor <cursoragent@cursor.com>
rayyan224
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
stevieraykatz
as code owners
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟢 B20FactoryLib.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockPolicyRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 96.68% | 97.22% | 98.39% | 96.89% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
Keep the Makefile default aligned with the repo's expected Python version; callers can still override with PYTHON=python3 for local pyenv setups. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Fork tests: all 613 passedbase/base is fully in sync with the base-std spec. |
ilikesymmetry
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expect_abi_decode_failed/expect_raw_abi_decode_failedhelpers on the smokeChainharness to assert Rust precompileAbiDecodeFailedrevert shape (selector || utf8), instead of typed custom errors.createB20variant now expects ABI decode failure, notInvalidVariant().getTokenAddress.t.solcomment describing Rust out-of-range variant behavior.python3(waspython3.13) somake smoke-setupworks on common pyenv installs.Test plan
make smoke-invariants— 12/12 invariants pass against local devnetmake smoke-factory— factory journey including out-of-range variant stepmake smoke— full smoke suite on devnet/zeronetMade with Cursor