Skip to content

fix: Default Properties #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webbrain-one wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Default Properties #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions src/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';

export const Filter = ({ onChange, placeholder }) => (
export const Filter = ({ onChange = null, placeholder }) => (
<div className="data-table-extensions-filter">
{/* eslint-disable-next-line jsx-a11y/control-has-associated-label */}
<label
Expand All @@ -23,12 +23,8 @@ Filter.propTypes = {
placeholder: PropTypes.string.isRequired,
};

Filter.defaultProps = {
onChange: null,
};

export const Export = props => {
const { className, onDropdown, onClick } = props;
const { className = '', onDropdown = null, onClick = null } = props;
return (
<>
{/* eslint-disable-next-line jsx-a11y/control-has-associated-label */}
Expand All @@ -51,21 +47,11 @@ Export.propTypes = {
onClick: PropTypes.func,
};

Export.defaultProps = {
className: '',
onDropdown: null,
onClick: null,
};

export const Print = props => (
export const Print = ({ onClick = null }) => (
// eslint-disable-next-line jsx-a11y/control-has-associated-label
<button type="button" className="print" onClick={() => props.onClick()} />
<button type="button" className="print" onClick={() => onClick()} />
);

Print.propTypes = {
onClick: PropTypes.func,
};

Print.defaultProps = {
onClick: null,
};