fix(ios): Podspec for React Native 0.84+ (RCT-Folly / install_modules_dependencies)#442
Open
christian-apollo wants to merge 1 commit intobamlab:masterfrom
Conversation
React Native 0.84 removes the standalone RCT-Folly pod when using prebuilt ReactNativeDependencies. Manual pod dependencies duplicated what install_modules_dependencies() already adds and caused CocoaPods to fail with 'Unable to find a specification for RCT-Folly'. Remove the redundant declarations and let install_modules_dependencies configure New Architecture deps for the installed RN version. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React Native 0.84+ no longer publishes a standalone
RCT-FollyCocoaPods spec when using prebuilt ReactNativeDependencies. The podspec still declareds.dependency "RCT-Folly"(and duplicated several deps thatinstall_modules_dependencies(s)already adds), which breakspod installwith:Changes
React-Codegen,RCT-Folly,RCTRequired,RCTTypeSafety, andReactCommon/turbomodule/corelines from the New Architecture branch.install_modules_dependencies(s)to attach the correct dependencies for the installed React Native version (including third-party / Folly via RN’s own helpers).This matches the approach recommended for native modules on current RN versions.
Testing
pod installin an app on RN 0.84.x with New Architecture enabledRelated: same fix is applied locally via
patch-packagein consumer apps until this ships in a release.Made with Cursor