fix(ios): catch NSException inside completionBlock to prevent TurboModule crash#439
Open
jtyreman-skewb wants to merge 1 commit intobamlab:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ios/ImageResizer.mm,transformImage()is called inside thecompletionBlockofloadImageWithURLRequest:, which executes asynchronously on a background thread.transformImagecan throw anNSException(for example whensaveImagereturnsNOunder memory pressure). This exception is not caught by the outer@try/@catch(which only wraps the synchronous setup code beforeloadImageWithURLRequest:is called).When the exception escapes the block, React Native's
RCTTurboModulemachinery callsconvertNSExceptionToJSErrorfrom the wrong thread, which then attempts to access Hermes JSI state, causing anEXC_BAD_ACCESShard crash.Stack trace seen in production (React Native 0.83.2 / New Architecture):
Fix
Wrap the
transformImagecall inside the completion block with its own@try/@catchso any exception is caught and forwarded to the JSrejectcallback rather than propagating into the TurboModule layer.This mirrors the pattern already used in the outer scope and is consistent with how other RCT modules handle async completion handlers.
Testing
catchblock now receives the error instead of the app crashing.