Skip to content

fix(commands): use background Bash to avoid shell timeout killing servers #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akdoan1 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −7
Open

fix(commands): use background Bash to avoid shell timeout killing servers #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/hook/commands/plannotator-annotate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ allowed-tools: Bash(plannotator:*)
disable-model-invocation: true
---

## Markdown Annotations
## Instructions

!`plannotator annotate $ARGUMENTS`
Run `plannotator annotate $ARGUMENTS` using the Bash tool with `run_in_background: true`. This starts an annotation server and opens the browser. The user will annotate the document and submit feedback — this may take a long time.

**Wait for the background task to complete before proceeding.** Do not interrupt or take other actions while the user is annotating.

## Your task

Expand Down
6 changes: 4 additions & 2 deletions apps/hook/commands/plannotator-last.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ allowed-tools: Bash(plannotator:*)
disable-model-invocation: true
---

## Message Annotations
## Instructions

!`plannotator annotate-last $ARGUMENTS`
Run `plannotator annotate-last $ARGUMENTS` using the Bash tool with `run_in_background: true`. This starts an annotation server and opens the browser. The user will annotate the message and submit feedback — this may take a long time.

**Wait for the background task to complete before proceeding.** Do not interrupt or take other actions while the user is annotating.

## Your task

Expand Down
8 changes: 5 additions & 3 deletions apps/hook/commands/plannotator-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ allowed-tools: Bash(plannotator:*)
disable-model-invocation: true
---

## Code Review Feedback
## Instructions

!`plannotator review $ARGUMENTS`
Run `plannotator review $ARGUMENTS` using the Bash tool with `run_in_background: true`. This starts a review server and opens the browser. The user will review code and submit feedback — this may take a long time.

**Wait for the background task to complete before proceeding.** Do not interrupt or take other actions while the user is reviewing.

## Your task

If the review above contains feedback or annotations, address them. If no changes were requested, acknowledge and continue.
When the command finishes, read its output. If it contains feedback or annotations, address them. If no changes were requested, acknowledge and continue.