feat(review): add configurable approval prompts#561
feat(review): add configurable approval prompts#561oorestisime wants to merge 2 commits intobacknotprop:mainfrom
Conversation
Let users override the agent message Plannotator sends after approving a code review. Keep the existing behavior by default while supporting runtime-specific overrides in ~/.plannotator/config.json.
|
in review |
Expose the new shared prompts module through @plannotator/shared so Bun can resolve it during hook builds and CI.
This is kinda drifting right now. Do you want me to make this more flexible including #570 ideas here? or maybe you are waiting first on some other opencode changes before that? either way just looking to see how i can be more helpful |
|
Hey I want this to work for all prompts. I'll start editing the PR now. Give me until tonight to try to get it into place. Also heads up, I just cut #606 to handle #570 (approve/annotate/dismiss flow for annotate mode), so that piece is already in flight. This PR can stay focused on expanding the configurable prompt surface to cover the other prompts in the system. |
Wonderful news! i didnt want to be invasive on first PR and do all prompts hehe. But agreed its much needed! Thanks so much for all this |
Summary
prompts.review.approvedandprompts.review.runtimes.<runtime>.approvedto~/.plannotator/config.jsonTesting
bun test packages/shared/prompts.test.ts packages/shared/feedback-templates.test.tsOpen Questions
staged,uncommitted,last-commit, etc.) before prompt customization expands further?packages/shared/agents.ts, but the prompt config duplicates that union inpackages/shared/config.tsto keep the vendored Pi config self-contained. Is there a better centralization path here?packages/shared/config.ts. If prompt customization grows beyond this first review-approval case, should this move toward a more structured typed config layer?Fixes: #558