feat(review): add local ESLint checks to code review - #1148
Open
leoreisdias wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Code review currently shows the diff, but it cannot surface project-specific ESLint feedback such as Rules of Hooks violations or missing
useEffectdependencies. Reviewers have to leave Plannotator and run ESLint separately, which makes these findings easy to miss.This adds an explicit ESLint check for local reviews. Plannotator uses the reviewed project's existing configuration, plugins, and project-local ESLint installation. It does not install dependencies, invoke package scripts, or use a bundled/global ESLint.
What changed
node_modulescheckout.Safety and review focus
The important areas to review are:
packages/shared/eslint-check.tsresolves only project-local ESLint entrypoints, passes file paths as argv without a shell, caps files/output, and shares one 30-second budget across config groups.Video
export-1785303880373.mp4
Verification
tsc --noEmitgit diff --checkThe full suite reached 2,205 passing tests with 99 skipped. One unrelated Bun API 404 guard exceeded its five-second timeout under full-suite load and passed immediately when rerun in isolation.