[BUGFIX] Only offer languages with page translation - #37
Open
achimfritz wants to merge 1 commit into
Open
achimfritz wants to merge 1 commit into
achimfritz wants to merge 1 commit into
Conversation
achimfritz
force-pushed
the
bugfix/languages
branch
2 times, most recently
from
September 25, 2026 13:37
a7a6345 to
ba44279
Compare
The link browser listed every language of the site for a page, even if the page had no translation in that language. Editors could thus create links to non-existing page translations. getAllLanguages() now checks which translations of the page exist and only returns those languages. The default language and "all languages" (-1) are always kept.
achimfritz
force-pushed
the
bugfix/languages
branch
from
September 25, 2026 13:38
ba44279 to
2cda71c
Compare
bmack
reviewed
Sep 25, 2026
| $site = $this->siteFinder->getSiteByPageId($pageId); | ||
| $languages = $site->getAvailableLanguages($this->getBackendUser(), true); | ||
| $queryBuilder = $this->connectionPool->getQueryBuilderForTable('pages'); | ||
| $queryBuilder->getRestrictions()->removeAll()->add(new DeletedRestriction()); |
Member
There was a problem hiding this comment.
you can do that but it's not WS-aware.
In v14 we do have methods in LocalizationRepository I think for this, but we can use this at a later version then.
bmack
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link browser listed every language of the site for a page, even if the page had no translation in that language. Editors could thus create links to non-existing page translations.
getAllLanguages() now checks which translations of the page exist and only returns those languages. The default language and "all languages" (-1) are always kept.