Skip to content

Add tag props to grid and cell components#42

Open
wab wants to merge 5 commits into
azz:masterfrom
wab:features/tags
Open

Add tag props to grid and cell components#42
wab wants to merge 5 commits into
azz:masterfrom
wab:features/tags

Conversation

@wab

@wab wab commented Jun 15, 2018

Copy link
Copy Markdown

As proposed in this issue #41 ...

Which allows to do something like :

<Grid is="ul">
  <Cell is="li" width={3}>
    item 1
   </Cell>
   <Cell is="li" width={3}>
      item 2
    </Cell>
  </Grid>

@azz azz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add docs?

Comment thread package.json Outdated
"semantic-release": "semantic-release pre && npm publish && semantic-release post"
},
"peerDependencies": {
"clean-tag": "^1.0.4",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a regular dependency

@azz

azz commented Jun 16, 2018

Copy link
Copy Markdown
Owner

The lib doesn't have any docs? :(

@wab

wab commented Jun 16, 2018

Copy link
Copy Markdown
Author

It's a "sublib" of styled-system ...
https://github.com/jxnblk/styled-system/tree/master/clean-tag

@jacob-fueled

Copy link
Copy Markdown

@wab bump. would quite like the ability to specify the tag to which renders as it current either precludes semantic HTML or forces divitis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants