fix: [InputGroup] refinements (ENG-46733, ENG-46734)#784
Open
isaquebock wants to merge 3 commits into
Open
Conversation
Merge focus indicators into the group's single focus-within ring by
suppressing every descendant focus ring inside the group (buttons,
anchors, comboboxes, inner input wrappers, raw inputs). Only the
outer group ring is visible when any child receives focus.
Add a size prop ('small' | 'medium' | 'large', default 'medium')
matching the sibling input primitives. The root renders data-size
and toggles h-7/h-8/h-10 accordingly; the addon adapts its horizontal
padding via ancestor-scoped variants so the row height stays visually
balanced across sizes.
Refs: ENG-46733, ENG-46734
isaquebock
marked this pull request as ready for review
July 23, 2026 17:33
isaquebock
marked this pull request as draft
July 23, 2026 17:34
isaquebock
marked this pull request as ready for review
July 23, 2026 21:02
gdsantana
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
focus-within.size?: 'small' | 'medium' | 'large'(defaultmedium); altura do grupo e padding do addon adaptam viadata-sizee propagam para inputs internos.How to test (mapeado 1:1 com Jira)
ENG-46733 — "InputGroup apresenta Double Focus"
Problema Jira: "InputGroup apresenta problema de Double Focus (dois estados de foco simultâneos/duplicados)."
Default.InputText,InputPassword,<a>link, elementorole="combobox"— todos delegam o ring ao grupo.ENG-46734 — "Não suporta sizes — deve adaptar aos inputs internos"
Problema Jira: "InputGroup não dá suporte a sizes. Internamente ele precisa aceitar os sizes dos inputs internos e se adaptar de acordo."
Sizes.size="small"→ altura 28px; addon compx-xs; inputs internos alinhados.size="medium"(default) → altura 32px; addon com padding padrão.size="large"→ altura 40px; addon compx-md.data-sizerefletindo o prop.Tests
30 passed, 1 skipped (skip pré-existente de
aria-requiredno axe — não relacionado).