Skip to content

[ENG-37265] refactor: remove default vertical scroll from list data table#541

Merged
robsongajunior merged 4 commits intomainfrom
refactor/ENG-37265-remove-table-vertical-scroll
Apr 30, 2026
Merged

[ENG-37265] refactor: remove default vertical scroll from list data table#541
robsongajunior merged 4 commits intomainfrom
refactor/ENG-37265-remove-table-vertical-scroll

Conversation

@HerbertJulio
Copy link
Copy Markdown
Contributor

@HerbertJulio HerbertJulio commented Apr 29, 2026

Summary

  • Change ListDataTable defaults so it does not scroll internally by default: scrollable from true to false, and scrollHeight default removed (empty string).
  • Bind :scrollable and :scrollHeight to the underlying PrimeDataTable (they were declared as props but not actually wired to the inner component, so callers couldn't enable scroll even when they tried).

Root cause

The wrapper exposed scrollable/scrollHeight props but never bound them to PrimeDataTable. The defaults still suggested an internal scroll, leaving consumers in an inconsistent state.

Changes

  • packages/webkit/src/core/list-data-table/components/list-data-table/list-data-table.vue
    • Defaults: scrollable: false, scrollHeight: ''
    • Template: bind :scrollable="scrollable" and :scrollHeight="scrollable ? scrollHeight : ''" on PrimeDataTable

Companion change in console-kit: aziontech/azion-console-kit#3505, where call sites that explicitly passed scrollHeight were also cleaned up.

Test plan

  • Storybook ListDataTable.stories.js default story shows no internal scroll.
  • Setting :scrollable="true" on a story explicitly re-enables scroll (default scrollHeight no longer hidden).
  • No regression on existing ListDataTable consumers in storybook.

@HerbertJulio HerbertJulio requested a review from a team as a code owner April 29, 2026 19:18
@HerbertJulio HerbertJulio force-pushed the refactor/ENG-37265-remove-table-vertical-scroll branch from 8524658 to 3b78abb Compare April 29, 2026 19:37
@robsongajunior robsongajunior added the design adjustment Improvement or fix in visual design label Apr 30, 2026
@robsongajunior robsongajunior merged commit bb36cc4 into main Apr 30, 2026
9 checks passed
@robsongajunior
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design adjustment Improvement or fix in visual design released

Development

Successfully merging this pull request may close these issues.

3 participants