Skip to content

ci: use the shared codestyle workflow - #30

Merged
Helias merged 1 commit into
masterfrom
ci/shared-codestyle
Sep 20, 2026
Merged

Helias merged 1 commit into
masterfrom
ci/shared-codestyle

Conversation

@Helias

@Helias Helias commented Sep 20, 2026

Copy link
Copy Markdown
Member

Calls azerothcore/reusable-workflows instead of keeping a local copy of the workflow and apps/ci/ci-codestyle.sh, the way core-build already does.

Summary by CodeRabbit

  • Chores
    • Updated code style checks to run for all pull requests.
    • Replaced the previous repository-specific style-checking process with a shared workflow.
    • Removed the former local style-check script.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2ee0bad5-2919-49ac-97f2-ce05d6f48c5c

📥 Commits

Reviewing files that changed from the base of the PR and between 40884a8 and 82bd40b.

📒 Files selected for processing (3)
  • .github/workflows/core_codestyle.yml
  • apps/ci/.gitkeep
  • apps/ci/ci-codestyle.sh
💤 Files with no reviewable changes (1)
  • apps/ci/ci-codestyle.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The codestyle workflow now runs on pull requests targeting any branch and delegates checks to a reusable workflow. The repository-specific codestyle script and its inline job configuration were removed.

Changes

Codestyle CI

Layer / File(s) Summary
Reusable codestyle workflow
.github/workflows/core_codestyle.yml, apps/ci/ci-codestyle.sh
Pull requests now trigger codestyle checks for any target branch. The workflow calls azerothcore/reusable-workflows/.github/workflows/codestyle_modules.yml@main and removes the local shell script and inline job steps.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description accurately states the main change, but it omits the required template sections for proposed changes, issues addressed, source, tests performed, and testing steps. Complete the pull request description with all required template sections. List the proposed changes, link any related issue or state that none applies, provide a source if available, document tests performed and the test environment, and a…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: replacing the local codestyle implementation with the shared workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Complete the pull request description with all required template sections. List the proposed changes, link any related issue or state that none applies, provide a source if available, document tests performed and the test environment, and add detailed steps to test the changes locally or in CI.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Helias
Helias merged commit 9ac4405 into master Sep 20, 2026
3 checks passed
@Helias
Helias deleted the ci/shared-codestyle branch September 20, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant