Skip to content

Fix redirecting and broken links reported by Search Console #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayeshrodz merged 1 commit into from
Oct 26, 2026
Merged

Fix redirecting and broken links reported by Search Console #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/engine/src/components/prose/elements.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,9 @@ export function Anchor({ href = '', onClick, ...props }) {
};
return <a href={href} onClick={go} {...props} />;
}
if (href.startsWith('lab/')) {
// Files of the lab tools live at the site root, whatever page links to them.
return <a href={`${import.meta.env.BASE_URL}${href}`} rel="nofollow" onClick={onClick} {...props} />;
}
return <a href={href} onClick={onClick} {...props} />;
}
14 changes: 12 additions & 2 deletions scripts/prerender.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,14 @@ const TEXT_TAGS = new Set(['p', 'h2', 'h3', 'h4', 'ul', 'ol', 'li', 'strong', 'e
/** Content links: "#/ch02/x" is a page of the same program, "#heading" a heading on this page. */
function link(href, programId) {
if (typeof href !== 'string') return null;
if (href.startsWith('#/')) return `${base}${programId ? `${programId}/` : ''}${href.slice(2)}`.replace(/\/\/+/g, '/');
if (href.startsWith('#/')) {
// The address the host serves, with its trailing slash, so a crawler never follows a redirect.
const [route, heading] = href.slice(2).split('#');
const path = `${base}${programId ? `${programId}/` : ''}${route}`.replace(/\/\/+/g, '/').replace(/\/?$/, '/');
return heading ? `${path}#${heading}` : path;
}
// Files of the lab tools ("lab/lab"): from the site root, whatever page links to them.
if (href.startsWith('lab/')) return `${base}${href}`;
if (href.startsWith('#') || /^https:\/\//.test(href) || href.startsWith('mailto:')) return href;
return null;
}
Expand All @@ -63,7 +70,10 @@ function renderNode(node, ctx) {
const tag = node.tag;
if (tag === 'a') {
const href = link(node.attrs?.href, ctx.programId);
return href ? `<a href="${escape(href)}">${render(node.c, ctx)}</a>` : render(node.c, ctx);
if (!href) return render(node.c, ctx);
// Lab tool files are for the lab command, not for search engines (robots.txt keeps them out).
const rel = href.startsWith(`${base}lab/`) ? ' rel="nofollow"' : '';
return `<a href="${escape(href)}"${rel}>${render(node.c, ctx)}</a>`;
}
if (tag === 'pre') return `<pre>${escape(text(node.c))}</pre>`;
if (!TEXT_TAGS.has(tag)) return render(node.c, ctx);
Expand Down