feat(databases-on-aws): add initial Aurora DSQL skill for Databases on AWS Plugin pt. 1#66
Conversation
anwesham-lab
force-pushed
the
feat/aurora-dsql-plugin
branch
6 times, most recently
from
2fb98e6 to
02bf4c2
Compare
anwesham-lab
changed the title
scottschreckengaust
left a comment
scottschreckengaust
left a comment
There was a problem hiding this comment.
Recommendation to place under aws-databases plugin
|
Please resolve conflicts also |
anwesham-lab
force-pushed
the
feat/aurora-dsql-plugin
branch
from
c05757c to
7da7ed7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anwesham-lab
changed the title
anwesham-lab
force-pushed
the
feat/aurora-dsql-plugin
branch
2 times, most recently
from
f7026b8 to
95ed68e
Compare
anwesham-lab
force-pushed
the
feat/aurora-dsql-plugin
branch
from
95ed68e to
e9a3f0e
Compare
anwesham-lab
force-pushed
the
feat/aurora-dsql-plugin
branch
from
e9a3f0e to
0fef241
Compare
anwesham-lab
dismissed
scottschreckengaust’s stale review
addressed this specific requested change, have fresh reviews to address from latest comments
This was intentional. When I ran invocation evaluations, I found that the skill was frequently skipping over languages.md or the development guide or would lose context on these top level requirements. The best practices are rules I want to always be paged into the skill regardless of using the development guide. We had similar consideration for removing from the development guide, but then the skill frequently missed references where it should recall use of the connectors or the right IAM structure inline based on that content alone. The intersectionality is what led to the duplication of these best practices in two locations. I'll adapt the load in section, specifically the Looking over & addressing other feedback though. |
anwesham-lab
force-pushed
the
feat/aurora-dsql-plugin
branch
from
0fef241 to
b34a541
Compare
|
All feedback addressed in latest force push. |
anwesham-lab
force-pushed
the
feat/aurora-dsql-plugin
branch
5 times, most recently
from
925348c to
040ada9
Compare
scottschreckengaust
left a comment
scottschreckengaust
left a comment
There was a problem hiding this comment.
upon determining where not-to-be-cloned items go
|
have tentatively moved evals to root level tools folder in latest commit, but we can consider maintaining evals locally. I think the visibility is good and follows stronger practices, but with the claude invocations, it does require being semgrep ignored. |
Add Aurora DSQL plugin with skill, MCP server config, hooks, and CLI scripts for managing serverless distributed SQL databases with PostgreSQL compatibility. Plugin components: - Skill with 7 workflows (schema, migration, tenant isolation, access control, DDL recreation, MySQL migration) - Docs-only MCP config (upgradeable to database operations) - PostToolUse hook for post-transact verification - 6 CLI scripts for cluster management and data loading - Modularized references: ddl-migrations (4 files), mysql-migrations (3 files), plus development guide, examples, language patterns, troubleshooting, onboarding, and access control Closes awslabs#45 Co-authored-by: anwesham-lab <64298192+anwesham-lab@users.noreply.github.com>
Collapse CLI Scripts listing and Workflow 5 (Scoped Roles) into concise pointers to their reference files, reducing upfront context without losing discoverability. These sections duplicated content the agent would naturally reach via access-control.md and scripts/README.md. Co-authored-by: anwesham-lab <64298192+anwesham-lab@users.noreply.github.com>
Renames aurora-dsql plugin to databases-on-aws as the top-level plugin for the AWS database portfolio. Migrates the DSQL skill into skills/dsql/ within the new plugin structure. Key changes: - Rename plugin from aurora-dsql to databases-on-aws - Split oversized reference files per Agent Skills spec (<100 lines) into subdirectories: auth/, examples/, platforms/, tools/ - Add AWS Knowledge MCP (awsknowledge) for verifying numeric limits with inline delegation hints in authoritative reference files - Add explicit Table Recreation Pattern warning for unsupported DDL (ALTER COLUMN TYPE, DROP COLUMN, DROP CONSTRAINT) - Add automated eval harness (triggering + functional with assertions) - Update marketplace.json, CODEOWNERS, and .mcp.json Co-authored-by: anwesham-lab <64298192+anwesham-lab@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Move evals from plugins/databases-on-aws/evals/ to tools/evals/databases-on-aws/ so eval files aren't shipped to end users when the plugin is installed (claude --plugin-dir ships the entire git-tracked directory tree). - Update .semgrepignore pattern to match new nested path - Fix broken URL (anthropics/agent-skills -> anthropics/skills) - Add plugin install command to evals README - Document evals/ directory structure in AGENTS.md under tools/ Co-authored-by: anwesham-lab <64298192+anwesham-lab@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
anwesham-lab
force-pushed
the
feat/aurora-dsql-plugin
branch
from
8bb7304 to
d6e6113
Compare
anwesham-lab
dismissed
scottschreckengaust’s stale review
Discussed offline and moved evals into root-level tools directory.
theagenticguy
left a comment
theagenticguy
left a comment
There was a problem hiding this comment.
Looks good. All prior review feedback (hook matcher mismatch, loader.sh --version parsing, predictable temp files, README update, typos, evals location) has been addressed. CI green, clean structure, sensible defaults (DSQL MCP disabled by default). Nice eval harness addition.
5 participants
Add
databases-on-awsplugin with skill, MCP server configuration (DSQL disabled by default, AWS Knowledge enabled by default), hooks, and CLI scripts for building with serverless distributed SQL databases.Per feedback, updated to match the Phase 1 proposal with Knowledge MCP lookup invocations for dynamic limit values (default fallbacks maintained for continuity, will update further to remove hardcoded values over time).
Broke down reference files further to conform to the 100 line limitations as well.
Related
RFC: #45
Changes
.claude-plugin/plugin.json): metadata, keywords, Apache-2.0 license.mcp.json): docs-only default, upgradeable to database operations viamcp-setup.mdskills/aurora-dsql/SKILL.md): 7 workflows covering schema creation, data migration, tenant isolation, access control, DDL table recreation, and MySQL-to-DSQL migrationhooks/hooks.json): PostToolUse prompt hook for post-transact verificationscripts/): 6 bash scripts for cluster lifecycle and data loading.claude-plugin/marketplace.jsonplugins/aurora-dsqlAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.