test(serve): add ModelBuilder.register framework attribute default tests - #6117
Open
aviruthen wants to merge 1 commit into
Open
test(serve): add ModelBuilder.register framework attribute default tests#6117aviruthen wants to merge 1 commit into
aviruthen wants to merge 1 commit into
Conversation
|
Claude finished @aviruthen's task in 2m 25s —— View job Code Review — test(serve): ModelBuilder.register framework defaults
SummaryThis is a tests-only PR and it looks clean. It adds a focused regression test for #5391, locking in that a freshly constructed I verified the tests against the source and they exercise the intended behavior accurately:
Minor observations (non-blocking)
Neither is worth blocking on. No correctness, security, or performance concerns — the PR adds no production code and the tests are well-scoped and accurate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add regression tests verifying a freshly constructed ModelBuilder exposes
framework and framework_version defaulted to None, so register() does not raise
AttributeError when the user never sets them.
Closes #5391
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.