Skip to content

Update error message on ModelBuilder when deploying from S3 checkpoint - #6111

Open
zhaoqizqwang wants to merge 2 commits into
aws:master-nova-follow-upsfrom
zhaoqizqwang:zhaoqi-nova-fix
Open

Update error message on ModelBuilder when deploying from S3 checkpoint#6111
zhaoqizqwang wants to merge 2 commits into
aws:master-nova-follow-upsfrom
zhaoqizqwang:zhaoqi-nova-fix

Conversation

@zhaoqizqwang

Copy link
Copy Markdown
Collaborator

Update error message on ModelBuilder when deploying from S3 checkpoint

  • Logging training job name when calling ModelTrainer.train()
  • Updating error message when missing required fields such as image_uri, base_job_name in ModelBuilder

# Validate required fields that would normally be auto-resolved.
missing_fields = []
if not self.image_uri:
missing_fields.append("image_uri")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the image uri for OSS serverful SMTJ as well?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would apply to both Nova and non-Nova models. I have updated the code in new commit to find image_uri from Hub based using base_model_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants