fix(sagemaker-core): drop tags before rebuilding TransformJob in tran… - #6110
fix(sagemaker-core): drop tags before rebuilding TransformJob in tran…#6110lucasjia-aws wants to merge 1 commit into
Conversation
…sform() Transformer.transform() submitted the CreateTransformJob request successfully, then rebuilt a local TransformJob resource from the same request dict. That dict contains a "tags" key (Tags is a member of the CreateTransformJobRequest shape), but the TransformJob resource model has no tags field and sets extra="forbid", so the constructor raised a pydantic ValidationError after the job was already created on SageMaker, leaving the caller without a job handle. Pop "tags" from the transformed dict before constructing TransformJob, mirroring the existing ProcessingJob fix (aws#5459). Add a regression test.
|
Claude finished @lucasjia-aws's task in 33s —— View job PR Review: drop tags before rebuilding TransformJob
Verdict: Looks good — ship it. ✅ The change is correct and minimal. Popping Observations (non-blocking):
No correctness, security, or performance concerns. Nice tight fix with a targeted regression test. |
|
related to issue #6090 |
…sform()
Transformer.transform() submitted the CreateTransformJob request successfully, then rebuilt a local TransformJob resource from the same request dict. That dict contains a "tags" key (Tags is a member of the CreateTransformJobRequest shape), but the TransformJob resource model has no tags field and sets extra="forbid", so the constructor raised a pydantic ValidationError after the job was already created on SageMaker, leaving the caller without a job handle.
Pop "tags" from the transformed dict before constructing TransformJob, mirroring the existing ProcessingJob fix (#5459). Add a regression test.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.