[DO NOT MERGE] test: verify PR coverage after #6082 routing fix - #6106
[DO NOT MERGE] test: verify PR coverage after #6082 routing fix#6106jam-jee wants to merge 1 commit into
Conversation
No-op comment in all 4 submodule __init__.py files. #6082 (merged) now routes PR unit-tests to the CDK-managed ci-health-unit-test-v3 project (--cov=sagemaker). This PR checks whether Codecov coverage now shows on the PR. 4 submodules => 4 uploads (works around unmerged #6056 after_n_builds:4). Same-repo branch from current master. Verification only.
|
Claude finished @jam-jee's task in 25s —— View job Review: verification PR (DO NOT MERGE)I read the full diff at # No-op line to trigger CI for a Codecov verification post-#6082 (DO NOT MERGE).
AssessmentNothing to flag. These are pure comment-only no-ops with no executable effect:
One minor placement note (non-blocking): in The PR does exactly what it intends: force all four unit-test jobs to run so each uploads coverage. Looks clean for its stated purpose. ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6106 +/- ##
=======================================
Coverage 69.80% 69.81%
=======================================
Files 548 548
Lines 65855 65855
=======================================
+ Hits 45970 45976 +6
+ Misses 19885 19879 -6 🚀 New features to boost your workflow:
|
Re-verification now that #6082 is merged (PR unit-tests route to the CDK-managed
ci-health-unit-test-v3project, which runs--cov=sagemaker). No-op comment in all 4 submodule__init__.pyfiles so every unit-test job runs and uploads coverage.Expected
With #6082 live, the unit-test jobs now run the fixed buildspec, so uploaded coverage.xml is product-only (test files excluded).
Known remaining caveats
after_n_builds: 4still on master, so this uses 4 submodules to produce 4 uploads.-B/-P/-F, so uploads carrybranch=empty /pr=false/ no flags. If that's still the case, coverage may still not attach to the PR (and the 4 uploads may collapse tosessions=1). This PR will tell us definitively whether the uploader fix is the last remaining blocker.Will be closed without merging once we read the result.