fix(serve): BedrockModelBuilder accepts BaseTrainer as model input - #6104
Open
amazeAmazing wants to merge 1 commit into
Open
fix(serve): BedrockModelBuilder accepts BaseTrainer as model input#6104amazeAmazing wants to merge 1 commit into
amazeAmazing wants to merge 1 commit into
Conversation
BedrockModelBuilder(model=trainer) now works for SFTTrainer, DPOTrainer, RLVRTrainer, etc. Previously only ModelTrainer and S3 URIs were supported.
cmahima
approved these changes
Jul 27, 2026
amazeAmazing
marked this pull request as ready for review
July 27, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BedrockModelBuilder(model=trainer) now works for SFTTrainer, DPOTrainer, RLVRTrainer, etc. Previously only ModelTrainer and S3 URIs were supported.
Issue #, if available:
Description of changes:
fix(serve): BedrockModelBuilder accepts BaseTrainer as model input
Problem
BedrockModelBuilder(model=trainer)failed whentrainerwas an SFTTrainer,DPOTrainer, RLVRTrainer, or any BaseTrainer subclass. Users had to extract the
S3 checkpoint URI manually:
Changes
BaseTrainerbranch in_fetch_model_package()to resolveoutput_model_package_arnfrom_latest_training_job_get_s3_artifacts()for HyperPod jobs wheremodel_artifactsis not populatedBaseTrainerTesting
Unit tests:
Integration tests by resolution path:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.