fix(dry_run): skip MLflow app creation and fix evaluator base_job_name - #6100
Open
amazeAmazing wants to merge 1 commit into
Open
fix(dry_run): skip MLflow app creation and fix evaluator base_job_name#6100amazeAmazing wants to merge 1 commit into
amazeAmazing wants to merge 1 commit into
Conversation
amazeAmazing
marked this pull request as ready for review
July 24, 2026 20:33
cmahima
approved these changes
Jul 24, 2026
amazeAmazing
force-pushed
the
fix/dry-run-mlflow-instance-type
branch
2 times, most recently
from
July 27, 2026 20:56
091ed6e to
eeba7e8
Compare
When dry_run=True, _resolve_mlflow_resource_arn now lists existing apps but skips creation and waiting. All trainers (SFT, DPO, RLVR, RLAIF, MultiTurnRL) forward dry_run to MLflow resolution. 9 unit tests.
amazeAmazing
force-pushed
the
fix/dry-run-mlflow-instance-type
branch
from
July 27, 2026 21:31
eeba7e8 to
7077a89
Compare
mujtaba1747
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
fix(dry_run): skip MLflow app creation and fix evaluator base_job_name
Problem
dry_run=Truetook 5-10 minutes when no MLflow app existed because_create_mlflow_config()triggered app creation and polled every 60swith a 600s timeout — before the dry_run check could short-circuit.
BenchMarkEvaluatorandCustomScorerEvaluator._evaluate_hyperpod()hardcoded job name asthe job name instead of respecting
self.base_eval_name.Changes
_resolve_mlflow_resource_arnand_create_mlflow_configacceptdry_run.When
dry_run=True, they list existing apps but skip creation and waiting.dry_runtoMLflow resolution.
MultiTurnRLTrainer.train()now supportsdry_run=True._evaluate_hyperpod()is consistent with SMTJ path.import timeinfinetune_utils.py.print()indpo_trainer.py.Testing
previously 5-10 minutes)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.