feature: ProcessingS3Output's s3_uri to be an optional field (5559)#5715
Draft
aviruthen wants to merge 1 commit intoaws:masterfrom
Draft
feature: ProcessingS3Output's s3_uri to be an optional field (5559)#5715aviruthen wants to merge 1 commit intoaws:masterfrom
ProcessingS3Output's s3_uri to be an optional field (5559)#5715aviruthen wants to merge 1 commit intoaws:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue requests that
ProcessingS3Output'ss3_urifield be optional (defaulting to None) in V3, matching V2'sProcessingOutput.destinationbehavior where None delegates S3 path generation to SageMaker. Two changes are needed: (1) In the auto-generated shapes file, changeProcessingS3Output.s3_urifrom a requiredstrfield toOptional[str] = None. (2) Inprocessing.py, update_normalize_outputs()to handle the case whereoutput.s3_output.s3_uriis None by auto-generating an S3 URI (the existing non-S3 scheme branch already does this), and update_processing_output_to_request_dict()to omitS3Urifrom the request dict when it's None (letting SageMaker service generate the path). The_normalize_outputsmethod currently doesurlparse(output.s3_output.s3_uri)which would crash on None, and also checksoutput.s3_outputexistence but nots3_uribeing None.Related Issue
Related issue: 5559
Changes Made
sagemaker-core/src/sagemaker/core/processing.pysagemaker-core/tests/unit/test_processing.pyAI-Generated PR
This PR was automatically generated by the PySDK Issue Agent.
Merge Checklist
prefix: descriptionformat