fix: Sanitize folder paths in terminal sendText to prevent command Injection#190
Open
aakashmandavilli96 wants to merge 1 commit intoaws:1.1from
Open
fix: Sanitize folder paths in terminal sendText to prevent command Injection#190aakashmandavilli96 wants to merge 1 commit intoaws:1.1from
aakashmandavilli96 wants to merge 1 commit intoaws:1.1from
Conversation
aws-ajangg
approved these changes
Apr 10, 2026
| +++ b/src/vs/platform/terminal/common/terminalEnvironment.ts | ||
| @@ -126,3 +126,29 @@ export function sanitizeCwd(cwd: string) | ||
| export function shouldUseEnvironmentVariableCollection(slc: IShellLaunchConfig): boolean { | ||
| return !slc.strictEnv; |
There was a problem hiding this comment.
will strictEnv always be set for ! or should we use it sparingly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of Changes
Testing
Screenshots/Videos
Additional Notes
Backporting
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.