Validate private API config during packaging - #2191
Open
alexgromero wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Applies the existing API Gateway resource policy validation in the package path before generating package resources.
This keeps
chalice packagealigned withchalice deployfor PRIVATE APIs: when no explicit API Gateway policy file is provided, a VPC endpoint id is required so chalice can generate the default resource policy.This is a fail-fast change for a PRIVATE API configuration that
chalice deployalready rejects and that previously produced an invalid packaged template.Testing
make prcheck.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.