Skip to content

fix(smus): reload project node after re-auth #8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kzr-at-amazon wants to merge 2 commits into
base: feature/smus
Choose a base branch
from
Open

fix(smus): reload project node after re-auth #8330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6988e3
reload project node after re-auth
kzr-at-amazon Nov 20, 2025
679c152
Merge branch 'feature/smus' into feature/smus
kzr-at-amazon Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/src/sagemakerunifiedstudio/explorer/activation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ export async function activate(extensionContext: vscode.ExtensionContext): Promi
if (connection) {
try {
await smusAuthProvider.reauthenticate(connection)
const projectNode = smusRootNode.getProjectSelectNode()
const project = projectNode.getProject()
Copy link
Contributor

@vpbhargav vpbhargav Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you close IDE, return to a state requiring re-auth, does the project node still exist in memory? Can you test? I would think not and won't that cause a NPE or is that somehow handled? If yes, please explain how.

Copy link
Contributor Author

@kzr-at-amazon kzr-at-amazon Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project node is always there. I have tested

  • root node is created in activate() link
  • Project node is created in root node constructor link

if (!project) {
await vscode.commands.executeCommand('aws.smus.switchProject')
}
treeDataProvider.refresh()

// IAM connections handle their own success messages
Expand Down
5 changes: 4 additions & 1 deletion packages/core/src/test/sagemakerunifiedstudio/explorer/activation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ describe('SMUS Explorer Activation', function () {

mockSmusRootNode = {
getChildren: sinon.stub().resolves([]),
getProjectSelectNode: sinon.stub().returns({ refreshNode: sinon.stub().resolves() }),
getProjectSelectNode: sinon.stub().returns({
getProject: sinon.stub().returns({ id: 'test-project', name: 'Test Project' }),
refreshNode: sinon.stub().resolves(),
}),
} as any

// Stub vscode APIs
Expand Down
Loading