Add PresignedFileDownload return type for presigned URL downloads #7004
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.transfer.s3.internal.model; | ||
|
|
||
| import java.util.concurrent.CompletableFuture; | ||
| import software.amazon.awssdk.annotations.SdkInternalApi; | ||
| import software.amazon.awssdk.transfer.s3.model.CompletedFileDownload; | ||
| import software.amazon.awssdk.transfer.s3.model.PresignedFileDownload; | ||
| import software.amazon.awssdk.transfer.s3.progress.TransferProgress; | ||
| import software.amazon.awssdk.utils.ToString; | ||
| import software.amazon.awssdk.utils.Validate; | ||
|
|
||
| @SdkInternalApi | ||
| public final class DefaultPresignedFileDownload implements PresignedFileDownload { | ||
| private final CompletableFuture<CompletedFileDownload> completionFuture; | ||
| private final TransferProgress progress; | ||
|
|
||
| public DefaultPresignedFileDownload(CompletableFuture<CompletedFileDownload> completionFuture, | ||
| TransferProgress progress) { | ||
| this.completionFuture = Validate.paramNotNull(completionFuture, "completionFuture"); | ||
| this.progress = Validate.paramNotNull(progress, "progress"); | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<CompletedFileDownload> completionFuture() { | ||
| return completionFuture; | ||
| } | ||
|
|
||
| @Override | ||
| public TransferProgress progress() { | ||
| return progress; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return ToString.builder("DefaultPresignedFileDownload") | ||
| .add("completionFuture", completionFuture) | ||
| .add("progress", progress) | ||
| .build(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.transfer.s3.model; | ||
|
|
||
| import java.util.concurrent.CompletableFuture; | ||
| import software.amazon.awssdk.annotations.SdkPublicApi; | ||
| import software.amazon.awssdk.annotations.ThreadSafe; | ||
|
|
||
| /** | ||
| * A download transfer of a single object from S3 using a presigned URL. | ||
| * | ||
| * <p>Unlike {@link FileDownload}, this type does not support pause/resume because presigned URLs | ||
| * have a limited lifetime and cannot be reliably resumed after expiration. | ||
|
Contributor
There was a problem hiding this comment. Is the expiry time only limitation for not implementing this for pause/resume? |
||
| */ | ||
| @SdkPublicApi | ||
| @ThreadSafe | ||
| public interface PresignedFileDownload extends ObjectTransfer { | ||
|
|
||
| @Override | ||
| CompletableFuture<CompletedFileDownload> completionFuture(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add equals and hashcode methods and also add test with EqualsVerifier something like DefaultDownloadTest