Skip to content

Introduce SNS Message Manager #6859

Merged
dagnir merged 16 commits intomasterfrom
feature/master/sns-message-manager
Apr 15, 2026
Merged

Introduce SNS Message Manager #6859
dagnir merged 16 commits intomasterfrom
feature/master/sns-message-manager

Conversation

@dagnir
Copy link
Copy Markdown
Contributor

@dagnir dagnir commented Apr 13, 2026

Motivation and Context

This change introduces the SNS Message Manager for 2.x, a library used to parse and validate messages received from SNS. This aims to provide the same functionality as SnsMessageManager from 1.x.

Fixes #1302.


This is merging the feature branch to master. All changes in the branch were reviewed individually:

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

zoewangg and others added 13 commits February 25, 2026 15:08
CertificateRetriever is responsible for fetching the certificate,
validating it, and caching it for future use.
* Implement host and CN resolution

SnsHostProvider implements the logic to determine the SNS endpoint for a
given region, as well as the expected common name of a signing
certificate used by SNS in that region.

Both pieces of information used to ensure that the certificate we use to
verify the message signature is legitimate.

* Remove use of internal API

Note: This is in codee that will be deleted.
* SnsMessageManager Impl

Provides an implementation of the SnsMessageManager. This mostly just
ties all the other classes implemented in previous PRs related to the
message manager.

* Review comments

* Allowlist usage of http client builder outside core

* Fix test
* Remove prototype files

 - Remove the original prototype files for the message manager in
   services/sns
 - Remove the kiro hooks not intended for release with the sns message
   manager

* Update version in POM

Parent version changed after merge from master
@dagnir dagnir added the api-surface-area-approved-by-team Indicate API surface area introduced by this PR has been approved by team label Apr 13, 2026
@dagnir dagnir marked this pull request as ready for review April 13, 2026 23:54
@dagnir dagnir requested a review from a team as a code owner April 13, 2026 23:54
 - toString() for models
 - Javadoc fixes
 - Make ctor protected
@dagnir dagnir enabled auto-merge April 14, 2026 22:18
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@dagnir dagnir added this pull request to the merge queue Apr 14, 2026
Merged via the queue into master with commit fa80722 Apr 15, 2026
39 of 41 checks passed
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api-surface-area-approved-by-team Indicate API surface area introduced by this PR has been approved by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNS Message Manager

3 participants